[FreeVMS] [Fwd: Andrews Update]

[Roar Thronæs]

On Tue, Aug 16, 2005 at 11:39:58AM -0400, Andrew Allison wrote:
> 
> I thought I would concentrate on dynamic for now, just for forward
> progress. With rtl_str_test I did make some design considerations for
> multiple descriptor types by putting a two character code for descriptor
> type. Right know I not sure why I choose CD for dynamic descriptor and not
> DD, momentary brain fade I think.

How long before you look through the dynamic descriptors and find errors?

As of the current release, valgrind found something it did not like when
running teststr.

I have also got some problems with telnet crashing inside malloc, and
that may be a sign of writing somewhere it should not.

The following is a fix for what valgrind complained about.

diff -u -r1.2 str_get1_dx.c
--- librtl/src/str_get1_dx.c    29 Dec 2004 11:53:39 -0000      1.2
+++ librtl/src/str_get1_dx.c    23 Aug 2005 10:37:24 -0000
@@ -116,7 +116,8 @@
                        DOSIGNAL(STR$_INSVIRMEM);
                        return STR$_INSVIRMEM;
                }
-               for (i=0; i < *word_integer_length; i++)
+               int minlen = character_string->dsc$w_length < *word_integer_length ? character_string->dsc$w_length : *word_integer_length;
+               for (i=0; i < minlen; i++)
                    new_memory[i] = character_string->dsc$a_pointer[i];
 
                free(character_string->dsc$a_pointer);

-- 
Regards,
Roar Thronæs